Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/observe/lib/src/bindable.dart

Issue 335943003: merge to trunk all changes from 36817 until 37378 under the packages: polymer, (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/code_transformers/test/resolver_test.dart ('k') | pkg/observe/lib/src/path_observer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/observe/lib/src/bindable.dart
===================================================================
--- pkg/observe/lib/src/bindable.dart (revision 37373)
+++ pkg/observe/lib/src/bindable.dart (working copy)
@@ -9,8 +9,10 @@
// TODO(jmesserly): Node.bind polyfill calls this "observable"
abstract class Bindable {
// TODO(jmesserly): since we have "value", should open be a void method?
- // TODO(jmesserly): not sure how I feel about open taking a variable number
- // of arguments, but it's the easiest way to make CompoundObserver work.
+ // Dart note: changed setValue to be "set value" and discardChanges() to
+ // be "get value". Also "set value" implies discard changes.
+ // TOOD(jmesserly): is this change too subtle? Is there any other way to
+ // make Bindable friendly in a world with getters/setters?
/// Initiates observation and returns the initial value.
/// The callback will be called with the updated [value].
« no previous file with comments | « pkg/code_transformers/test/resolver_test.dart ('k') | pkg/observe/lib/src/path_observer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698