merge to trunk all changes from 36817 until 37378 under the packages: polymer,

pkg/polymer_expressions/test/bindings_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library bindings_test;
 
 import 'dart:async';
 import 'dart:html';
 
 import 'package:observe/observe.dart';
 import 'package:observe/mirrors_used.dart'; // make test smaller.
 import 'package:observe/src/dirty_check.dart' show dirtyCheckZone;
 import 'package:polymer_expressions/polymer_expressions.dart';
 import 'package:smoke/mirrors.dart' as smoke;
 import 'package:template_binding/template_binding.dart' show
     TemplateBindExtension, templateBind;
 import 'package:unittest/html_config.dart';
 
 import 'package:unittest/unittest.dart';
 
 var testDiv;
 
 main() => dirtyCheckZone().run(() {
   useHtmlConfiguration();
+  smoke.useMirrors();
 
   group('bindings', () {
     var stop = null;
     setUp(() {
       document.body.append(testDiv = new DivElement());
     });
 
     tearDown(() {
       testDiv.remove();
       testDiv = null;
     });
 
     test('should update binding when data changes', () {
       var model = new NotifyModel();
       var binding = new PolymerExpressions()
           .prepareBinding('x', null, null)(model, null, false);
       expect(binding.value, isNull);
       model.x = "hi";
       return new Future(() {
         expect(binding.value, 'hi');
       });
     });
 
+    // regression test for issue 19296
+    test('should not throw when data changes', () {
+      var model = new NotifyModel();
+      var tag = new Element.html('<template>'
+          '<template repeat="{{ i in x }}">{{ i }}</template></template>');
+      TemplateBindExtension.bootstrap(tag);
+      var template = templateBind(tag);
+      testDiv.append(template.createInstance(model, new PolymerExpressions()));
+
+      return new Future(() {
+        model.x = [1, 2, 3];
+      }).then(_nextMicrotask).then((_) {
+        expect(testDiv.text,'123');
+      });
+    });
+
+
     test('should update text content when data changes', () {
       var model = new NotifyModel('abcde');
       var tag = new Element.html(
       '<template><span>{{x}}</span></template>');
       TemplateBindExtension.bootstrap(tag);
       var template = templateBind(tag);
       testDiv.append(template.createInstance(model, new PolymerExpressions()));
 
       var el;
       return new Future(() {
@@ skipping 235 matching lines @@
   get y => _y;
   set y(value) {
     _y = notifyPropertyChange(#y, _y, value);
   }
 }
 
 class _NullTreeSanitizer implements NodeTreeSanitizer {
   void sanitizeTree(Node node) {}
 }
 final _nullTreeSanitizer = new _NullTreeSanitizer();