merge to trunk all changes from 36817 until 37378 under the packages: polymer,

pkg/polymer/lib/src/build/common.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Common methods used by transfomers.
 library polymer.src.build.common;
 
 import 'dart:async';
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/parser.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 import 'package:barback/barback.dart';
 import 'package:html5lib/dom.dart' show Document;
 import 'package:html5lib/parser.dart' show HtmlParser;
 import 'package:path/path.dart' as path;
 import 'package:observe/transformer.dart' show ObservableTransformer;
 import 'package:source_maps/span.dart' show Span;
 
+const _ignoredErrors = const [
+  'unexpected-dash-after-double-dash-in-comment',
+  'unexpected-char-in-comment',
+];
+
 /// Parses an HTML file [contents] and returns a DOM-like tree. Adds emitted
 /// error/warning to [logger].
 Document _parseHtml(String contents, String sourcePath, TransformLogger logger,
-    {bool checkDocType: true}) {
+    {bool checkDocType: true, bool showWarnings: true}) {
   // TODO(jmesserly): make HTTP encoding configurable
-  var parser = new HtmlParser(contents, encoding: 'utf8', generateSpans: true,
-      sourceUrl: sourcePath);
+  var parser = new HtmlParser(contents, encoding: 'utf8',
+      generateSpans: true, sourceUrl: sourcePath);
   var document = parser.parse();
 
   // Note: errors aren't fatal in HTML (unless strict mode is on).
   // So just print them as warnings.
-  for (var e in parser.errors) {
-    if (checkDocType || e.errorCode != 'expected-doctype-but-got-start-tag') {
-      logger.warning(e.message, span: e.span);
+  if (showWarnings) {
+    for (var e in parser.errors) {
+      if (_ignoredErrors.contains(e.errorCode)) continue;
+      if (checkDocType || e.errorCode != 'expected-doctype-but-got-start-tag') {
+        logger.warning(e.message, span: e.span);
+      }
     }
   }
   return document;
 }
 
 /// Additional options used by polymer transformers
 class TransformOptions {
   /// List of entrypoints paths. The paths are relative to the package root and
   /// are represented using posix style, which matches the representation used
   /// in asset ids in barback. If null, anything under 'web/' or 'test/' is
@@ skipping 47 matching lines @@
 
   Future<Document> readPrimaryAsHtml(Transform transform) {
     var asset = transform.primaryInput;
     var id = asset.id;
     return asset.readAsString().then((content) {
       return _parseHtml(content, id.path, transform.logger,
         checkDocType: options.isHtmlEntryPoint(id));
     });
   }
 
-  Future<Document> readAsHtml(AssetId id, Transform transform) {
+  Future<Document> readAsHtml(AssetId id, Transform transform,
+      {bool showWarnings: true}) {
     var primaryId = transform.primaryInput.id;
     bool samePackage = id.package == primaryId.package;
     var url = spanUrlFor(id, transform);
     return transform.readInputAsString(id).then((content) {
       return _parseHtml(content, url, transform.logger,
-        checkDocType: samePackage && options.isHtmlEntryPoint(id));
+        checkDocType: samePackage && options.isHtmlEntryPoint(id),
+        showWarnings: showWarnings);
     });
   }
 
   Future<bool> assetExists(AssetId id, Transform transform) =>
       transform.getInput(id).then((_) => true).catchError((_) => false);
 
   String toString() => 'polymer ($runtimeType)';
 }
 
 /// Gets the appropriate URL to use in a [Span] to produce messages
@@ skipping 46 matching lines @@
       from: builder.join('/', builder.dirname(sourceId.path)));
 }
 
 
 /// Convert system paths to asset paths (asset paths are posix style).
 String _systemToAssetPath(String assetPath) {
   if (path.Style.platform != path.Style.windows) return assetPath;
   return path.posix.joinAll(path.split(assetPath));
 }
 
-
-/// Parse [code] using analyzer.
-CompilationUnit parseCompilationUnit(String code) {
-  var errorListener = new _ErrorCollector();
-  var reader = new CharSequenceReader(code);
-  var scanner = new Scanner(null, reader, errorListener);
-  var token = scanner.tokenize();
-  var parser = new Parser(null, errorListener);
-  return parser.parseCompilationUnit(token);
-}
-
-class _ErrorCollector extends AnalysisErrorListener {
-  final errors = <AnalysisError>[];
-  onError(error) => errors.add(error);
-}
-
 /// These names have meaning in SVG or MathML, so they aren't allowed as custom
 /// tags. See [isCustomTagName].
 const invalidTagNames = const {
   'annotation-xml': '',
   'color-profile': '',
   'font-face': '',
   'font-face-src': '',
   'font-face-uri': '',
   'font-face-format': '',
   'font-face-name': '',
   'missing-glyph': '',
 };
 
 /// Returns true if this is a valid custom element name. See:
 /// <http://w3c.github.io/webcomponents/spec/custom/#dfn-custom-element-type>
 bool isCustomTagName(String name) {
   if (name == null || !name.contains('-')) return false;
   return !invalidTagNames.containsKey(name);
 }
 
 /// Regex to split names in the 'attributes' attribute, which supports 'a b c',
 /// 'a,b,c', or even 'a b,c'. This is the same as in `lib/src/declaration.dart`.
 final ATTRIBUTES_REGEX = new RegExp(r'\s|,');
 
 const POLYMER_EXPERIMENTAL_HTML = 'packages/polymer/polymer_experimental.html';