Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 33593002: PNaClize and update the 'Devguide -> Running' page of the documentation. (Closed)

Created:
7 years, 2 months ago by eliben
Modified:
7 years, 2 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More conversion + added images #

Patch Set 3 : Cleanups #

Total comments: 4

Patch Set 4 : Ben's review and more links to running sdk examples #

Patch Set 5 : Switch to different images #

Patch Set 6 : f* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -90 lines) Patch
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/running.rst View 1 2 3 4 15 chunks +131 lines, -89 lines 0 comments Download
A + native_client_sdk/src/doc/images/icon128.png View 1 2 3 4 Binary file 0 comments Download
A native_client_sdk/src/doc/images/icon16.png View 1 2 3 4 Binary file 0 comments Download
M native_client_sdk/src/doc/sdk/examples.rst View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eliben
Note that I did not try to actually follow through the CWS-related parts because I ...
7 years, 2 months ago (2013-10-22 16:22:49 UTC) #1
eliben
7 years, 2 months ago (2013-10-22 16:23:12 UTC) #2
binji
https://codereview.chromium.org/33593002/diff/80001/native_client_sdk/src/doc/devguide/devcycle/running.rst File native_client_sdk/src/doc/devguide/devcycle/running.rst (right): https://codereview.chromium.org/33593002/diff/80001/native_client_sdk/src/doc/devguide/devcycle/running.rst#newcode205 native_client_sdk/src/doc/devguide/devcycle/running.rst:205: to run any application under the ``examples`` directory where ...
7 years, 2 months ago (2013-10-22 17:14:27 UTC) #3
eliben
PTAL https://codereview.chromium.org/33593002/diff/80001/native_client_sdk/src/doc/devguide/devcycle/running.rst File native_client_sdk/src/doc/devguide/devcycle/running.rst (right): https://codereview.chromium.org/33593002/diff/80001/native_client_sdk/src/doc/devguide/devcycle/running.rst#newcode205 native_client_sdk/src/doc/devguide/devcycle/running.rst:205: to run any application under the ``examples`` directory ...
7 years, 2 months ago (2013-10-22 18:01:51 UTC) #4
binji
lgtm
7 years, 2 months ago (2013-10-22 18:27:27 UTC) #5
eliben
7 years, 2 months ago (2013-10-22 19:53:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r230184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698