Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 335923007: [Telemetry] Make our Enabled/Disabled annotations match what the bots run. (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu, zty
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make our Enabled/Disabled annotations match what the bots run. This change is not intended to add or remove anything from the bots. It is merely making it so that 'run_benchmark list' will return the bot's current set of tests for android. This will enable us to just run all enabled benchmarks and add/remove benchmarks without a master restart. BUG=350973, 163503, 388885 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280427

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : yar (yet another rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/browsermark.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/canvasmark.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/chrome_proxy.py View 1 2 3 4 5 5 chunks +15 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/endure.py View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/html5gaming.py View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/media.py View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/memory.py View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/peacekeeper.py View 1 2 3 4 5 7 chunks +7 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/polymer_load.py View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/scirra.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/start_with_url.py View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/startup.py View 1 2 3 4 5 6 chunks +9 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/thread_times.py View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
tonyg
6 years, 6 months ago (2014-06-26 04:05:28 UTC) #1
dtu
lgtm
6 years, 5 months ago (2014-06-26 21:19:35 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-06-27 15:19:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/335923007/80001
6 years, 5 months ago (2014-06-27 15:20:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-06-27 17:40:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 17:43:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/25413) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22614)
6 years, 5 months ago (2014-06-27 17:43:40 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-06-27 17:53:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/335923007/80001
6 years, 5 months ago (2014-06-27 17:54:57 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-06-27 18:08:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 18:10:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/25421) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/22630)
6 years, 5 months ago (2014-06-27 18:10:56 UTC) #12
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-06-27 19:41:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/335923007/100001
6 years, 5 months ago (2014-06-27 19:43:01 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 22:09:25 UTC) #15
Message was sent while issue was closed.
Change committed as 280427

Powered by Google App Engine
This is Rietveld 408576698