Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 335923004: aura-linux: Fixes super/hyper/meta key support. (Closed)

Created:
6 years, 6 months ago by Yuki
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

aura-linux: Fixes super/hyper/meta key support. gtk-immodule expects GDK_SUPER_MASK, GDK_HYPER_MASK and GDK_META_MASK to be set appropriately in GdkEventKey. Supports these modifier flags. BUG=388183 TEST=Done manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -84 lines) Patch
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.h View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 5 chunks +137 lines, -84 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuki
Could you review this CL?
6 years, 6 months ago (2014-06-24 09:11:11 UTC) #1
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-24 17:51:15 UTC) #2
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 6 months ago (2014-06-25 03:04:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/335923004/1
6 years, 6 months ago (2014-06-25 03:06:29 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 10:23:21 UTC) #5
Message was sent while issue was closed.
Change committed as 279665

Powered by Google App Engine
This is Rietveld 408576698