Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 335903004: Fix mojo build on android. (Closed)

Created:
6 years, 6 months ago by qsr
Modified:
6 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix mojo build on android. Android stl library has bugs related to std::set -> https://code.google.com/p/android/issues/detail?id=69153 This change allow this code to compile on android. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
qsr
6 years, 6 months ago (2014-06-19 21:48:29 UTC) #1
viettrungluu
lgtm
6 years, 6 months ago (2014-06-19 22:10:17 UTC) #2
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-06-19 22:15:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/335903004/1
6 years, 6 months ago (2014-06-19 22:18:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 03:25:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 03:36:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85776)
6 years, 6 months ago (2014-06-20 03:36:43 UTC) #7
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-06-20 05:43:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/335903004/1
6 years, 6 months ago (2014-06-20 05:46:42 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 09:48:15 UTC) #10
Message was sent while issue was closed.
Change committed as 278657

Powered by Google App Engine
This is Rietveld 408576698