Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5383)

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 335893002: Support to remove passwords by date_synced timestamp. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vabr's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.h
diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h
index 585f64db75f1bf7b22efa815dbb3b4613543b8cc..edc2c4e9f302efc10708aa97db4cf5ab81036e8a 100644
--- a/chrome/browser/password_manager/password_store_x.h
+++ b/chrome/browser/password_manager/password_store_x.h
@@ -46,12 +46,21 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
const autofill::PasswordForm& form,
password_manager::PasswordStoreChangeList* changes) = 0;
virtual bool RemoveLogin(const autofill::PasswordForm& form) = 0;
- virtual bool RemoveLoginsCreatedBetween(const base::Time& delete_begin,
- const base::Time& delete_end) = 0;
+
+ // Removes all logins created/synced from |delete_begin| onwards (inclusive)
+ // and before |delete_end|. You may use a null Time value to do an unbounded
+ // delete in either direction.
+ virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
+ base::Time delete_end) = 0;
+ virtual bool RemoveLoginsSyncedBetween(
+ base::Time delete_begin,
+ base::Time delete_end,
+ password_manager::PasswordStoreChangeList* changes) = 0;
+
virtual bool GetLogins(const autofill::PasswordForm& form,
PasswordFormList* forms) = 0;
- virtual bool GetLoginsCreatedBetween(const base::Time& get_begin,
- const base::Time& get_end,
+ virtual bool GetLoginsCreatedBetween(base::Time get_begin,
+ base::Time get_end,
PasswordFormList* forms) = 0;
virtual bool GetAutofillableLogins(PasswordFormList* forms) = 0;
virtual bool GetBlacklistLogins(PasswordFormList* forms) = 0;
@@ -79,6 +88,9 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
virtual password_manager::PasswordStoreChangeList
RemoveLoginsCreatedBetweenImpl(const base::Time& delete_begin,
const base::Time& delete_end) OVERRIDE;
+ virtual password_manager::PasswordStoreChangeList
+ RemoveLoginsSyncedBetweenImpl(base::Time delete_begin,
+ base::Time delete_end) OVERRIDE;
virtual void GetLoginsImpl(
const autofill::PasswordForm& form,
AuthorizationPromptPolicy prompt_policy,

Powered by Google App Engine
This is Rietveld 408576698