Support to remove passwords by date_synced timestamp.

chrome/browser/sync/test/integration/passwords_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/passwords_helper.h"
 
 #include "base/compiler_specific.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/waitable_event.h"
@@ skipping 46 matching lines @@
     // Quit the message loop to wake up passwords_helper::GetLogins.
     base::MessageLoopForUI::current()->Quit();
   }
 
  private:
   std::vector<PasswordForm>* result_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStoreConsumerHelper);
 };
 
+// PasswordForm::date_synced is a local field. Therefore it may be different
+// across clients.
+void ClearSyncDateField(std::vector<PasswordForm>* forms) {
+  for (std::vector<PasswordForm>::iterator it = forms->begin();
+       it != forms->end();
+       ++it) {
+    it->date_synced = base::Time();
+  }
+}
+
 }  // namespace
 
 namespace passwords_helper {
 
 void AddLogin(PasswordStore* store, const PasswordForm& form) {
   ASSERT_TRUE(store);
   base::WaitableEvent wait_event(true, false);
   store->AddLogin(form);
   store->ScheduleTask(base::Bind(&PasswordStoreCallback, &wait_event));
   wait_event.Wait();
@@ skipping 53 matching lines @@
 PasswordStore* GetVerifierPasswordStore() {
   return PasswordStoreFactory::GetForProfile(test()->verifier(),
                                              Profile::IMPLICIT_ACCESS).get();
 }
 
 bool ProfileContainsSamePasswordFormsAsVerifier(int index) {
   std::vector<PasswordForm> verifier_forms;
   std::vector<PasswordForm> forms;
   GetLogins(GetVerifierPasswordStore(), verifier_forms);
   GetLogins(GetPasswordStore(index), forms);
+  ClearSyncDateField(&forms);
   bool result =
       password_manager::ContainsSamePasswordForms(verifier_forms, forms);

[Nicolas Zea, 2014/06/17 21:41:11]

Does it make sense to modify this method instead to not compare date_synced?

[vasilii, 2014/06/18 10:00:57]

ContainsSamePasswordForms() resides in components/. If it was just for sync
integration, I'd agree. But now it can be reused in non-sync scenarios where
date_synced may be important. PasswordForm::operator== definitely should compare
all fields.

   if (!result) {
     LOG(ERROR) << "Password forms in Verifier Profile:";
     for (std::vector<PasswordForm>::iterator it = verifier_forms.begin();
          it != verifier_forms.end(); ++it) {
       LOG(ERROR) << *it << std::endl;
     }
     LOG(ERROR) << "Password forms in Profile" << index << ":";
     for (std::vector<PasswordForm>::iterator it = forms.begin();
          it != forms.end(); ++it) {
       LOG(ERROR) << *it << std::endl;
     }
   }
   return result;
 }
 
 bool ProfilesContainSamePasswordForms(int index_a, int index_b) {
   std::vector<PasswordForm> forms_a;
   std::vector<PasswordForm> forms_b;
   GetLogins(GetPasswordStore(index_a), forms_a);
   GetLogins(GetPasswordStore(index_b), forms_b);
+  ClearSyncDateField(&forms_a);
+  ClearSyncDateField(&forms_b);
   bool result = password_manager::ContainsSamePasswordForms(forms_a, forms_b);
   if (!result) {
     LOG(ERROR) << "Password forms in Profile" << index_a << ":";
     for (std::vector<PasswordForm>::iterator it = forms_a.begin();
          it != forms_a.end(); ++it) {
       LOG(ERROR) << *it << std::endl;
     }
     LOG(ERROR) << "Password forms in Profile" << index_b << ":";
     for (std::vector<PasswordForm>::iterator it = forms_b.begin();
          it != forms_b.end(); ++it) {
@@ skipping 175 matching lines @@
   form.origin = GURL(base::StringPrintf(kIndexedFakeOrigin, index));
   form.username_value =
       base::ASCIIToUTF16(base::StringPrintf("username%d", index));
   form.password_value =
       base::ASCIIToUTF16(base::StringPrintf("password%d", index));
   form.date_created = base::Time::Now();
   return form;
 }
 
 }  // namespace passwords_helper