Support to remove passwords by date_synced timestamp.

chrome/browser/password_manager/native_backend_kwallet_x.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[vabr (Chromium), 2014/06/17 15:28:41]

Many of the comments I made for Gnome apply here as well. Please take them into
account as appropriate.

[vasilii, 2014/06/17 17:24:14]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_KWALLET_X_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_KWALLET_X_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
@@ skipping 27 matching lines @@
 
   virtual bool Init() OVERRIDE;
 
   // Implements NativeBackend interface.
   virtual password_manager::PasswordStoreChangeList AddLogin(
       const autofill::PasswordForm& form) OVERRIDE;
   virtual bool UpdateLogin(
       const autofill::PasswordForm& form,
       password_manager::PasswordStoreChangeList* changes) OVERRIDE;
   virtual bool RemoveLogin(const autofill::PasswordForm& form) OVERRIDE;
-  virtual bool RemoveLoginsCreatedBetween(
-      const base::Time& delete_begin, const base::Time& delete_end) OVERRIDE;
+  virtual bool RemoveLoginsCreatedBetween(base::Time delete_begin,
+                                          base::Time delete_end) OVERRIDE;
+  virtual bool RemoveLoginsSyncedBetween(
+      base::Time delete_begin,
+      base::Time delete_end,
+      password_manager::PasswordStoreChangeList* changes) OVERRIDE;
   virtual bool GetLogins(const autofill::PasswordForm& form,
                          PasswordFormList* forms) OVERRIDE;
-  virtual bool GetLoginsCreatedBetween(const base::Time& get_begin,
-                                       const base::Time& get_end,
+  virtual bool GetLoginsCreatedBetween(base::Time get_begin, base::Time get_end,
                                        PasswordFormList* forms) OVERRIDE;
   virtual bool GetAutofillableLogins(PasswordFormList* forms) OVERRIDE;
   virtual bool GetBlacklistLogins(PasswordFormList* forms) OVERRIDE;
 
  protected:
   // Invalid handle returned by WalletHandle().
   static const int kInvalidKWalletHandle = -1;
 
   // Internally used by Init(), but also for testing to provide a mock bus.
   bool InitWithBus(scoped_refptr<dbus::Bus> optional_bus);
@@ skipping 20 matching lines @@
   // Reads PasswordForms from the wallet that match the given signon_realm.
   bool GetLoginsList(PasswordFormList* forms,
                      const std::string& signon_realm,
                      int wallet_handle);
 
   // Reads PasswordForms from the wallet with the given autofillability state.
   bool GetLoginsList(PasswordFormList* forms,
                      bool autofillable,
                      int wallet_handle);
 
-  // Reads PasswordForms from the wallet created in the given time range.
+  // Reads PasswordForms from the wallet created/synced in the given time range.
   bool GetLoginsList(PasswordFormList* forms,
                      const base::Time& begin,
                      const base::Time& end,
-                     int wallet_handle);
+                     int wallet_handle,
+                     bool date_is_creation);
 
   // Helper for some of the above GetLoginsList() methods.
   bool GetAllLogins(PasswordFormList* forms, int wallet_handle);
 
   // Writes a list of PasswordForms to the wallet with the given signon_realm.
   // Overwrites any existing list for this signon_realm. Removes the entry if
   // |forms| is empty. Returns true on success.
   bool SetLoginsList(const PasswordFormList& forms,
                      const std::string& signon_realm,
                      int wallet_handle);
 
+  bool RemoveLoginsBetween(base::Time delete_begin, base::Time delete_end,
+                           bool date_is_creation,
+                           password_manager::PasswordStoreChangeList* changes);
+
   // Opens the wallet and ensures that the "Chrome Form Data" folder exists.
   // Returns kInvalidWalletHandle on error.
   int WalletHandle();
 
   // Serializes a list of PasswordForms to be stored in the wallet.
   static void SerializeValue(const PasswordFormList& forms, Pickle* pickle);
 
   // Deserializes a list of PasswordForms from the wallet.
   // |size_32| controls reading the size field within the pickle as 32 bits.
   // We used to use Pickle::WriteSize() to write the number of password forms,
@@ skipping 25 matching lines @@
 
   // The name of the wallet we've opened. Set during Init().
   std::string wallet_name_;
   // The application name (e.g. "Chromium"), shown in KWallet auth dialogs.
   const std::string app_name_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeBackendKWallet);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_KWALLET_X_H_