gpu: Only estimate parent compositor run time when needed

gpu: Only estimate parent compositor run time when needed

When BeginFrame scheduling is enabled, the browser compositor
automatically adjusts the deadline it passes down to the renderer to
account for its own draw time. Make sure we don't also subtract the
estimated draw time in the renderer.

BUG=359566
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277774

[Sami, 2014-06-13 17:26:08]

Hey Brian, do you think this is the right place to fix this? Basically the
problem is that we tweak the deadline both here: 
 
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

and in the renderer scheduler. I'd prefer to keep the adjustment in the browser
because eventually we should be able to make it more accurate there.

Not sure if this is limited just to Android though.

[brianderson, 2014-06-13 17:42:57]

On 2014/06/13 17:26:08, Sami wrote:
> Hey Brian, do you think this is the right place to fix this? Basically the
> problem is that we tweak the deadline both here: 
>  
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...
> 
> and in the renderer scheduler. I'd prefer to keep the adjustment in the
browser
> because eventually we should be able to make it more accurate there.
> 
> Not sure if this is limited just to Android though.

lgtm.

Good catch. Did Android use a different OutputSurface before? I remember this
flag being set correctly when it was introduced.

[Sami, 2014-06-13 17:50:21]

+piman@ for owners'.

On 2014/06/13 17:42:57, brianderson wrote:
> Good catch. Did Android use a different OutputSurface before? I remember this
> flag being set correctly when it was introduced.

We switched to the delegated output surface with ubercomp so this may have
regressed then. Kinda surprised it didn't show up on the bots.

[piman, 2014-06-13 20:46:43]

https://codereview.chromium.org/335873002/diff/1/content/renderer/gpu/composi...
File content/renderer/gpu/compositor_output_surface.cc (right):

https://codereview.chromium.org/335873002/diff/1/content/renderer/gpu/composi...
content/renderer/gpu/compositor_output_surface.cc:79: #if defined(OS_ANDROID)
Why android only? All platforms but Mac* use delegated.
Can we make this common between platforms?

*Mac may go delegated for 37.

[Sami, 2014-06-16 13:15:04]

https://codereview.chromium.org/335873002/diff/1/content/renderer/gpu/composi...
File content/renderer/gpu/compositor_output_surface.cc (right):

https://codereview.chromium.org/335873002/diff/1/content/renderer/gpu/composi...
content/renderer/gpu/compositor_output_surface.cc:79: #if defined(OS_ANDROID)
On 2014/06/13 20:46:43, piman wrote:
> Why android only? All platforms but Mac* use delegated.
> Can we make this common between platforms?
> 
> *Mac may go delegated for 37.

Yeah, I was wondering if this should be done more generally. Is this really a
question of delegated vs. non-delegated, though? On Android the browser
compositor runtime is subtracted from the deadline, so we need this to avoid
doing the same adjustment twice. I'm not sure if that happens on other platforms
yet, but I'm thinking it should since the browser is in the best place to do
that adjustment.

[Sami, 2014-06-17 00:19:23]

Chatted with Brian and found a way to make this more generic. PTAL.

[piman, 2014-06-17 03:12:30]

If Brian is happy with this then lgtm.

[brianderson, 2014-06-17 05:24:34]

lgtm

[Sami, 2014-06-17 13:04:59]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:05:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/335873002/20001

[commit-bot: I haz the power, 2014-06-17 15:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 15:39:26]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Sami, 2014-06-17 15:43:37]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-17 15:45:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/335873002/20001

[commit-bot: I haz the power, 2014-06-17 16:06:36]

Change committed as 277774