Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 335853003: Handle null content in ContentChange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index f39ba53b16f4a0ae276d8a453b160db3e5723fe4..2306e8bfeb7b4a640ecdf08821868a37a5d2f064 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -303,6 +303,10 @@ class AnalysisServer {
void updateContent(Map<String, ContentChange> changes) {
changes.forEach((file, change) {
AnalysisContext analysisContext = _getAnalysisContext(file);
+ // TODO(paulberry): handle the case where a file is referred to by more
+ // than one context (e.g package A depends on package B using a local
+ // path, user has both packages open for editing in separate contexts,
+ // and user modifies a file in package B).
if (analysisContext != null) {
Source source = _getSource(file);
if (change.offset == null) {
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/domain_analysis.dart » ('j') | pkg/analysis_server/lib/src/protocol.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698