Don't move uneditable paragraph contents in CompositeEditCommand::moveParagraphContentsToNewBlockIfN

Source/core/editing/CompositeEditCommand.cpp

Index: Source/core/editing/CompositeEditCommand.cpp
diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp
index f450f39a50e55eebb6626fb0c77c8c62a4e63225..04354411c54eef667da88bd1f51727e719b225f8 100644
--- a/Source/core/editing/CompositeEditCommand.cpp
+++ b/Source/core/editing/CompositeEditCommand.cpp
@@ -902,6 +902,9 @@ PassRefPtrWillBeRawPtr<Element> CompositeEditCommand::moveParagraphContentsToNew
 
     document().updateLayoutIgnorePendingStylesheets();
 
+    if (!isEditablePosition(pos, ContentIsEditable, DoNotUpdateStyle))

[Yuta Kitamura, 2014/06/13 07:29:01]

I'm not 100% certain whether this check should live here.

This check may perhaps be caller's responsibility, i.e.
each command should check this condition before calling
moveParagraphContentsToNewBlockIfNecessary(), and this
function just ASSERTs that this precondition is met.

WDYT?

[yosin_UTC9, 2014/06/13 09:01:27]

Agree. It should be caller's responsibility.

+        return nullptr;
+
     // It's strange that this function is responsible for verifying that pos has not been invalidated
     // by an earlier call to this function.  The caller, applyBlockStyle, should do this.
     VisiblePosition visiblePos(pos, VP_DEFAULT_AFFINITY);