Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4932)

Unified Diff: chrome/common/extensions/api/file_system_provider_internal.idl

Issue 335753004: [fsp] Cleanup handling errors for operation requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/file_system_provider_internal.idl
diff --git a/chrome/common/extensions/api/file_system_provider_internal.idl b/chrome/common/extensions/api/file_system_provider_internal.idl
index c349e9a9c2198906e900fcbcec026424154cbf4d..974f69b20a46e7c85e7b52c27852146eac9dc253 100644
--- a/chrome/common/extensions/api/file_system_provider_internal.idl
+++ b/chrome/common/extensions/api/file_system_provider_internal.idl
@@ -13,13 +13,6 @@ namespace fileSystemProviderInternal {
static void unmountRequestedSuccess(DOMString fileSystemId,
long requestId);
- // Internal. Error callback of the <code>onUnmountRequested</code>
- // event. Must be called if unmounting fails.
- static void unmountRequestedError(
- DOMString fileSystemId,
- long requestId,
- fileSystemProvider.ProviderError error);
-
// Internal. Success callback of the <code>onGetMetadataRequested</code>
// event. Must be called if metadata is available.
static void getMetadataRequestedSuccess(
@@ -27,13 +20,6 @@ namespace fileSystemProviderInternal {
long requestId,
fileSystemProvider.EntryMetadata metadata);
- // Internal. Error callback of the <code>onGetMetadataRequested</code>
- // event. Must be called when obtaining metadata fails.
- static void getMetadataRequestedError(
- DOMString fileSystemId,
- long requestId,
- fileSystemProvider.ProviderError error);
-
// Internal. Success callback of the <code>onReadDirectoryRequested</code>
// event. Can be called multiple times per request.
static void readDirectoryRequestedSuccess(
@@ -42,39 +28,18 @@ namespace fileSystemProviderInternal {
fileSystemProvider.EntryMetadata[] entries,
boolean hasMore);
- // Internal. Error callback of the <code>onReadDirectoryRequested</code>
- // event. Must be called when reading a directory fails.
- static void readDirectoryRequestedError(
- DOMString fileSystemId,
- long requestId,
- fileSystemProvider.ProviderError error);
-
// Internal. Success callback of the <code>onOpenFileRequested</code> event.
// Must be called, when opening succeeds.
static void openFileRequestedSuccess(
DOMString fileSystemId,
long requestId);
- // Internal. Error callback of the <code>onOpenFileRequested</code> event.
- // Must be called when opening fails.
- static void openFileRequestedError(
- DOMString fileSystemId,
- long requestId,
- fileSystemProvider.ProviderError error);
-
// Internal. Success callback of the <code>onCloseFileRequested</code>
// event. Must be called, when closing succeeds.
static void closeFileRequestedSuccess(
DOMString fileSystemId,
long requestId);
- // Internal. Error callback of the <code>onCloseFileRequested</code> event.
- // Must be called when closing fails.
- static void closeFileRequestedError(
- DOMString fileSystemId,
- long requestId,
- fileSystemProvider.ProviderError error);
-
// Internal. Success callback of the <code>onReadFileRequested</code>
// event. Can be called multiple times per request.
static void readFileRequestedSuccess(
@@ -83,12 +48,13 @@ namespace fileSystemProviderInternal {
ArrayBuffer data,
boolean hasMore);
- // Internal. Error callback of the <code>onReadFileRequested</code>
- // event. Must be called when reading a file fails.
- static void readFileRequestedError(
+ // Internal. Error callback of all of the operation requests. Must be called
+ // if an operation fails.
+ static void operationRequestedError(
DOMString fileSystemId,
long requestId,
fileSystemProvider.ProviderError error);
+
};
};

Powered by Google App Engine
This is Rietveld 408576698