Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: chrome/browser/chromeos/file_system_provider/request_manager.h

Issue 335753004: [fsp] Cleanup handling errors for operation requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/request_manager.h
diff --git a/chrome/browser/chromeos/file_system_provider/request_manager.h b/chrome/browser/chromeos/file_system_provider/request_manager.h
index c1cb5d5553944e0b1ce78d6644d29c636e4a300c..4518bfa76e283d23ab84d3babf5ebbc636a20d79 100644
--- a/chrome/browser/chromeos/file_system_provider/request_manager.h
+++ b/chrome/browser/chromeos/file_system_provider/request_manager.h
@@ -59,7 +59,9 @@ class RequestManager {
// Error callback invoked by the providing extension in response to
// Execute(). It can be called at most once. It can be also called if the
// request is aborted due to a timeout.
- virtual void OnError(int request_id, base::File::Error error) = 0;
+ virtual void OnError(int request_id,
+ scoped_ptr<RequestValue> result,
+ base::File::Error error) = 0;
};
// Observes activities in the request manager.
@@ -103,7 +105,9 @@ class RequestManager {
// Handles error response for the |request_id|. If handling the error fails,
// returns false. Always disposes the request.
- bool RejectRequest(int request_id, base::File::Error error);
+ bool RejectRequest(int request_id,
+ scoped_ptr<RequestValue> response,
+ base::File::Error error);
// Sets a custom timeout for tests. The new timeout value will be applied to
// new requests

Powered by Google App Engine
This is Rietveld 408576698