Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

Issue 335753004: [fsp] Cleanup handling errors for operation requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
index 9d028cb819c14f2612c3a5fd66b4096fba705245..b7853d16007a2b359d695fb17fe5a2f55c1841a5 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
@@ -178,9 +178,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute_NoListener) {
}
TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {
- using extensions::api::file_system_provider_internal::
- OpenFileRequestedSuccess::Params;
-
LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
CallbackLogger callback_logger;
@@ -207,9 +204,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {
}
TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {
- using extensions::api::file_system_provider_internal::OpenFileRequestedError::
- Params;
-
LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
CallbackLogger callback_logger;
@@ -226,7 +220,9 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {
EXPECT_TRUE(open_file.Execute(kRequestId));
- open_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
+ open_file.OnError(kRequestId,
+ scoped_ptr<RequestValue>(new RequestValue()),
+ base::File::FILE_ERROR_TOO_MANY_OPENED);
ASSERT_EQ(1u, callback_logger.events().size());
CallbackLogger::Event* event = callback_logger.events()[0];
EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());

Powered by Google App Engine
This is Rietveld 408576698