Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 335743002: updateLayerPositionsAfterLayout shouldn't have a RenderGeometryMap (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

updateLayerPositionsAfterLayout shouldn't have a RenderGeometryMap This CL remove the RenderGeometryMap from updateLayerPositionsAfterLayout. The only remaining use of the geometry map was to compute an argument for RenderLayerScrollableArea::positionOverflowControls. However, it turns out it doesn't matter what value we pass to positionOverflowControls at this point. By removing the RenderGeometryMap, this CL makes updateLayerPositionsAfterLayout twice as fast. Historically, the overflow controls were backed by NSViews, which meant they needed to be positioned in absolute space by the widget tree. Now, however, they're either drawn by Blink or composited by cc. If the overflow controls are painted by Blink, we're reposition them immediately before painting. If the overflow controls are composited, we'll subtract out the offsetFromRoot before passing the values to cc. In both cases, it doesn't matter care what value we pass here. We should eventually remove this function call from this codepath. This isn't the correct codepath in which to position the overflow controls. However, we can save that work for a future CL. R=esprehn@chromium.org BUG=383636, 382548 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176070

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -43 lines) Patch
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 3 chunks +9 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-12 23:17:14 UTC) #1
esprehn
lgtm https://codereview.chromium.org/335743002/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/335743002/diff/1/Source/core/rendering/RenderLayer.cpp#newcode274 Source/core/rendering/RenderLayer.cpp:274: // presumably becaus the normal time to position ...
6 years, 6 months ago (2014-06-12 23:38:53 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 23:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/335743002/20001
6 years, 6 months ago (2014-06-12 23:47:58 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:58:58 UTC) #5
Message was sent while issue was closed.
Change committed as 176070

Powered by Google App Engine
This is Rietveld 408576698