Added layout tests for all shorthand property.

Added layout tests for all shorthand property.

This is a preparation patch for implementing all shorthand property.
This patch adds layout tests, which are currently failing.
After implementing all shorthand correctly, the tests will pass.

Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176201

[tasak, 2014-06-13 13:06:47]

Would you review this CL?

I separated the large patch uploaded in:
https://codereview.chromium.org/216803002/

and created a patch for "1) tests but failing".

[rune, 2014-06-13 13:32:53]

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand-css-text.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand-css-text.html:26: <pre id='console'></pre>
Is this necessary because you have div rules in the stylesheet that will affect
it? A console will be create if necessary from js-test.js.

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand-css-text.html:34: var cssRules = styleSheet =
document.styleSheets[1].cssRules;
The styleSheet variable looks like a left-over.

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand.html:37: <div id='target1'>green color, no
background-color</div>
This text matches the expected result with "all" implemented. So does target2,
but not target3 or target8. I haven't checked all cases. Could you make that
consistent?

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/getComp...
File LayoutTests/fast/css/getComputedStyle/getComputedStyle-all.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/getComp...
LayoutTests/fast/css/getComputedStyle/getComputedStyle-all.html:15: <pre
id="console"></pre>
This element is not required.

[tasak, 2014-06-16 07:07:28]

Thank you for reviewing.

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand-css-text.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand-css-text.html:26: <pre id='console'></pre>
On 2014/06/13 13:32:52, rune wrote:
> Is this necessary because you have div rules in the stylesheet that will
affect
> it? A console will be create if necessary from js-test.js.

Done.

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand-css-text.html:34: var cssRules = styleSheet =
document.styleSheets[1].cssRules;
On 2014/06/13 13:32:52, rune wrote:
> The styleSheet variable looks like a left-over.

Thanks. Done.

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/getComp...
File LayoutTests/fast/css/getComputedStyle/getComputedStyle-all.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/getComp...
LayoutTests/fast/css/getComputedStyle/getComputedStyle-all.html:15: <pre
id="console"></pre>
On 2014/06/13 13:32:53, rune wrote:
> This element is not required.

Done.

[tasak, 2014-06-16 07:12:07]

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand.html:37: <div id='target1'>green color, no
background-color</div>
On 2014/06/13 13:32:53, rune wrote:
> This text matches the expected result with "all" implemented. So does target2,
> but not target3 or target8. I haven't checked all cases. Could you make that
> consistent?
> 

I'm sorry. I would like to confirm.
What should I do? These text should be "all is not-implemented" version?

[rune, 2014-06-16 07:40:23]

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand.html:37: <div id='target1'>green color, no
background-color</div>
On 2014/06/16 07:12:07, tasak wrote:
> On 2014/06/13 13:32:53, rune wrote:
> > This text matches the expected result with "all" implemented. So does
target2,
> > but not target3 or target8. I haven't checked all cases. Could you make that
> > consistent?
> > 
> 
> I'm sorry. I would like to confirm.
> What should I do? These text should be "all is not-implemented" version?

So, I thought these tests were all failing wrt the spec for "all". Does the text
match the current actual results? If so, it's ok. Adding "all not implemented"
to the tests that are failing according to the spec would be a good hint, I
think.

[tasak, 2014-06-16 09:09:46]

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
File LayoutTests/fast/css/all-shorthand.html (right):

https://codereview.chromium.org/335733003/diff/1/LayoutTests/fast/css/all-sho...
LayoutTests/fast/css/all-shorthand.html:37: <div id='target1'>green color, no
background-color</div>
On 2014/06/16 07:40:23, rune wrote:
> On 2014/06/16 07:12:07, tasak wrote:
> > On 2014/06/13 13:32:53, rune wrote:
> > > This text matches the expected result with "all" implemented. So does
> target2,
> > > but not target3 or target8. I haven't checked all cases. Could you make
that
> > > consistent?
> > > 
> > 
> > I'm sorry. I would like to confirm.
> > What should I do? These text should be "all is not-implemented" version?
> 
> So, I thought these tests were all failing wrt the spec for "all". Does the
text
> match the current actual results? If so, it's ok. Adding "all not implemented"
> to the tests that are failing according to the spec would be a good hint, I
> think.

I see.
Thank you.
I updated the text. Now the text matches the current actual results.

[rune, 2014-06-16 09:19:46]

lgtm

[tasak, 2014-06-16 10:57:13]

On 2014/06/16 09:19:46, rune wrote:
> lgtm

Thank you.

[tasak, 2014-06-16 10:57:16]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-06-16 10:58:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tasak@google.com/335733003/40001

[commit-bot: I haz the power, 2014-06-16 12:02:00]

Change committed as 176201