Issue 33573002: Revert "Revert "cache SkImage::Info calculation in lazypixelref""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33573002: Revert "Revert "cache SkImage::Info calculation in lazypixelref"" (Closed)

Created:
7 years, 2 months ago by reed1

Modified:
7 years, 2 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "Revert "cache SkImage::Info calculation in lazypixelref"" This reverts commit 81eba32ab10f9210c742938819cf1218be5611c9. ImageDecoder is changed to allow info to be NULL, since it is an output-only parameter. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11896

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -16 lines)			Patch
M	src/images/SkImageDecoder.cpp	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/lazy/SkLazyPixelRef.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/lazy/SkLazyPixelRef.cpp	View	4 chunks	+21 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r11896.

Expand Messages | Collapse Messages