Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335703005: Remove redandunt chrome/common include from chrome/browser/search_engines (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting, battre
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove redundant chrome/common include from chrome/browser/search_engines Move pref names kSearchProviderOverrides, kSearchProviderOverridesVersion, kCountryIDAtInstall and kGeoIDAtInstall to components/search_engines. Remove include "chrome/common/*" if possible. BUG=371535 TEST=build TBR=battre@chromium.org for include fix under chrome/browser/profile_resetter Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279724

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : Remove kGeoIDAtInstall #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -44 lines) Patch
M chrome/browser/profile_resetter/brandcoded_default_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/default_search_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 2 3 4 3 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M components/search_engines/search_engines_pref_names.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/search_engines/search_engines_pref_names.cc View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
hashimoto
6 years, 6 months ago (2014-06-23 22:17:38 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/335703005/diff/20001/components/search_engines/search_engines_pref_names.h File components/search_engines/search_engines_pref_names.h (right): https://codereview.chromium.org/335703005/diff/20001/components/search_engines/search_engines_pref_names.h#newcode32 components/search_engines/search_engines_pref_names.h:32: extern const char kGeoIDAtInstall[]; // OBSOLETE This obsolete ...
6 years, 6 months ago (2014-06-25 00:37:12 UTC) #2
hashimoto
https://codereview.chromium.org/335703005/diff/20001/components/search_engines/search_engines_pref_names.h File components/search_engines/search_engines_pref_names.h (right): https://codereview.chromium.org/335703005/diff/20001/components/search_engines/search_engines_pref_names.h#newcode32 components/search_engines/search_engines_pref_names.h:32: extern const char kGeoIDAtInstall[]; // OBSOLETE On 2014/06/25 00:37:12, ...
6 years, 6 months ago (2014-06-25 01:16:14 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-25 07:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/335703005/80001
6 years, 6 months ago (2014-06-25 07:02:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 09:27:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 09:31:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/76221)
6 years, 6 months ago (2014-06-25 09:31:02 UTC) #8
hashimoto
TBRing battre@chromium.org for include fix under chrome/browser/profile_resetter
6 years, 6 months ago (2014-06-25 16:18:03 UTC) #9
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-25 16:18:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/335703005/80001
6 years, 6 months ago (2014-06-25 16:18:38 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 16:23:10 UTC) #12
Message was sent while issue was closed. 
Change committed as 279724

Powered by Google App Engine
This is Rietveld 408576698