[Isolates] Pass current isolate address to the regexp native functions

Pass current isolate address to the regexp native functions. Immediate effect of this change is a modest speed up(<4%)on a few tests but we will need isolate pointer to pass it directly into Handle constructors and Factory calls for further RegExp optimizations.


BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=5463

[Vitaly Repeshko, 2010-09-14 17:59:33]

LGTM if we can avoid the hairy stuff on ARM.


Thanks,
Vitaly

http://codereview.chromium.org/3357023/diff/9001/4010
File src/api.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4010#newcode2578
src/api.cc:2578: i::Isolate* isolate = self->GetHeap()->isolate();
You can now use self->GetIsolate()

http://codereview.chromium.org/3357023/diff/9001/4011
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4011#newcode1925
src/arm/macro-assembler-arm.cc:1925: mov(r0,
Operand(ExternalReference::isolate_address()));
Please try using "ip" register here.

http://codereview.chromium.org/3357023/diff/9001/4012
File src/arm/regexp-macro-assembler-arm.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4012#newcode63
src/arm/regexp-macro-assembler-arm.cc:63: *       - Isolate* isolate    
(Address of the current isolate)
nit: Align "(".

http://codereview.chromium.org/3357023/diff/9001/4025
File src/v8.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4025#newcode108
src/v8.cc:108: // TODO: move lo and hi to isolate
nit: Use TODO(isolates).

http://codereview.chromium.org/3357023/diff/9001/4027
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4027#newcode2858
src/x64/macro-assembler-x64.cc:2858: // First six arguments are passed in
registers on Linux/Mac.
Linux/Mac -> other platforms.

[yurys, 2010-09-15 11:40:40]

Some code depends on ip staying the same after native calls. I found that e.g.
GenericBinaryOpStub::HandleBinaryOpSlowCases would break if I used ip as a
scratch register in CallCFunction. As an alternative we could try to pass a
scratch register as an argument to CallCFunction but that would differ from what
we do on the other platforms.

http://codereview.chromium.org/3357023/diff/9001/4010
File src/api.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4010#newcode2578
src/api.cc:2578: i::Isolate* isolate = self->GetHeap()->isolate();
On 2010/09/14 17:59:33, Vitaly wrote:
> You can now use self->GetIsolate()

Done.

http://codereview.chromium.org/3357023/diff/9001/4012
File src/arm/regexp-macro-assembler-arm.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4012#newcode63
src/arm/regexp-macro-assembler-arm.cc:63: *       - Isolate* isolate    
(Address of the current isolate)
On 2010/09/14 17:59:33, Vitaly wrote:
> nit: Align "(".

Done.

http://codereview.chromium.org/3357023/diff/9001/4025
File src/v8.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4025#newcode108
src/v8.cc:108: // TODO: move lo and hi to isolate
On 2010/09/14 17:59:33, Vitaly wrote:
> nit: Use TODO(isolates).

Done.

http://codereview.chromium.org/3357023/diff/9001/4027
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/3357023/diff/9001/4027#newcode2858
src/x64/macro-assembler-x64.cc:2858: // First six arguments are passed in
registers on Linux/Mac.
On 2010/09/14 17:59:33, Vitaly wrote:
> Linux/Mac -> other platforms.

Done.

[yurys, 2010-09-15 15:25:10]

Isolate* argument on ARM is passed as was proposed by vitalyr who introduced
CallCFunctionHelper in macro-assembler-arm.* Thanks for your advice Vitaly.

[Vitaly Repeshko, 2010-09-15 15:26:33]

LGTM