Issue 335693004: Hook up content/browser compile in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335693004: Hook up content/browser compile in GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Hook up content/browser compile in GN build. I've started changing the way grit headers are included so the include path is relative to the root gen path (liek internal Google does). This also means we don't accumulate another implicit include path for every grit target in the build. Updates the grit target a bit so that it also includes the generated id file as a dependency, since if this changes everything will need to be re-run. This adds a bunch of tracing targets required by the content browser build TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277124

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+532 lines, -38 lines)			Patch
M	BUILD.gn	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/BUILD.gn	View	1 2	1 chunk	+30 lines, -8 lines	0 comments	Download
M	content/browser/BUILD.gn	View	1 2 3 4 5 6	8 chunks	+34 lines, -20 lines	0 comments	Download
A	content/browser/tracing/BUILD.gn	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	content/browser/tracing/tracing_ui.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/public/renderer/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/protobuf/proto_library.gni	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/third_party/angle/BUILD.gn	View	1 2 3 4 5	5 chunks	+63 lines, -4 lines	0 comments	Download
A	tools/gn/secondary/third_party/angle/angle_commit.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
A	tools/gn/secondary/third_party/trace-viewer/BUILD.gn	View		1 chunk	+320 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/tools/grit/grit_rule.gni	View	1 2 3 4	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 6 months ago (2014-06-13 23:18:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #7 manually as r277124 (presubmit successful).

Expand Messages | Collapse Messages

Issue 335693004: Hook up content/browser compile in GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Messages