Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler.h

Issue 335693003: Don't stop and restart GCM when extension/app is being updated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_gcm_app_handler.h
diff --git a/chrome/browser/extensions/extension_gcm_app_handler.h b/chrome/browser/extensions/extension_gcm_app_handler.h
index 8c7bc3363cdc411b056e8b2e747ff3247717b14e..3ea49af6fad83f194383b36b39fc246500c29d0f 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler.h
+++ b/chrome/browser/extensions/extension_gcm_app_handler.h
@@ -56,10 +56,15 @@ class ExtensionGCMAppHandler : public gcm::GCMAppHandler,
const gcm::GCMClient::SendErrorDetails& send_error_details) OVERRIDE;
protected:
+ // Could be overridden by testing purpose.
virtual void OnUnregisterCompleted(const std::string& app_id,
gcm::GCMClient::Result result);
+ virtual void AddAppHandler(const std::string& app_id);
+ virtual void RemoveAppHandler(const std::string& app_id);
- private:
+ gcm::GCMDriver* GetGCMDriver() const;
+
+private:
friend class BrowserContextKeyedAPIFactory<ExtensionGCMAppHandler>;
// ExtensionRegistryObserver implementation.
@@ -72,8 +77,6 @@ class ExtensionGCMAppHandler : public gcm::GCMAppHandler,
virtual void OnExtensionUninstalled(content::BrowserContext* browser_context,
const Extension* extension) OVERRIDE;
- gcm::GCMDriver* GetGCMDriver() const;
-
// BrowserContextKeyedAPI implementation.
static const char* service_name() { return "ExtensionGCMAppHandler"; }
static const bool kServiceIsNULLWhileTesting = true;

Powered by Google App Engine
This is Rietveld 408576698