Issue 335673003: athena: Add shadows to the windows in overview mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335673003: athena: Add shadows to the windows in overview mode. (Closed)

Created:
6 years, 6 months ago by sadrul

Modified:
6 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

athena: Add shadows to the windows in overview mode. Add shadows to the windows in overview mode. The shadows are destroyed when going out of overview mode. BUG=376353 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276807

Patch Set 1 #

Patch Set 2 : tot-merge #

Total comments: 2

Patch Set 3 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	athena/wm/window_overview_mode.cc	View	1 2	4 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

oshima

https://codereview.chromium.org/335673003/diff/20001/athena/wm/window_overview_mode.cc File athena/wm/window_overview_mode.cc (right): https://codereview.chromium.org/335673003/diff/20001/athena/wm/window_overview_mode.cc#newcode254 athena/wm/window_overview_mode.cc:254: ScopedVector<wm::Shadow> shadows_; can't you store the shadow in the ...

6 years, 6 months ago (2014-06-12 19:15:24 UTC) #2

sadrul

6 years, 6 months ago (2014-06-12 19:37:51 UTC) #3

sadrul

6 years, 6 months ago (2014-06-12 21:38:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r276807 (presubmit successful).

Expand Messages | Collapse Messages