Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 335673002: Report devtools frontend crashes during layout tests (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Report devtools frontend crashes during layout tests BUG=383089 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/browser/webkit_test_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-12 15:50:48 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-12 16:03:13 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-12 16:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/335673002/1
6 years, 6 months ago (2014-06-12 16:09:00 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 20:53:25 UTC) #5
Message was sent while issue was closed.
Change committed as 276797

Powered by Google App Engine
This is Rietveld 408576698