Have one, long-lived map for bound functions.

Have one, long-lived map for bound functions.

This avoids creating a new map for every bound function. Bonus: some cleanup in Runtime_FunctionBindArguments.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21839

[Jakob Kummerow, 2014-06-12 15:19:02]

Toon: PTAL.

Slava: FYI.

[Toon Verwaest, 2014-06-12 21:53:35]

lgtm with suggestion

https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc#newcode271
src/bootstrapper.cc:271: enum ForBoundFunctionMode {
I'd rather name this

enum FunctionMapMode {
  REGULAR_FUNCTION_MAP,
  BOUND_FUNCTION_MAP
}

And perhaps you could even merge it with the above PrototypePropertyMode, since
BOUND_FUNCTION always implies DONT_ADD_PROTOTYPE:

enum FunctionMode {
  // With prototype.
  FUNCTION_WITH_WRITEABLE_PROTOTYPE,
  FUNCTION_WITH_READONLY_PROTOTYPE,
  // Without prototype.
  FUNCTION_WITHOUT_PROTOTYPE,
  BOUND_FUNCTION
}

[Jakob Kummerow, 2014-06-13 11:43:13]

I like that suggestion.

https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc#newcode271
src/bootstrapper.cc:271: enum ForBoundFunctionMode {
On 2014/06/12 21:53:35, Toon Verwaest wrote:
> I'd rather name this
> 
> enum FunctionMapMode {
>   REGULAR_FUNCTION_MAP,
>   BOUND_FUNCTION_MAP
> }
> 
> And perhaps you could even merge it with the above PrototypePropertyMode,
since
> BOUND_FUNCTION always implies DONT_ADD_PROTOTYPE:
> 
> enum FunctionMode {
>   // With prototype.
>   FUNCTION_WITH_WRITEABLE_PROTOTYPE,
>   FUNCTION_WITH_READONLY_PROTOTYPE,
>   // Without prototype.
>   FUNCTION_WITHOUT_PROTOTYPE,
>   BOUND_FUNCTION
> }

Done.

[Jakob Kummerow, 2014-06-13 12:19:19]

Committed patchset #2 manually as r21839 (presubmit successful).