Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 335633003: Do not skip subtrees with wheel or touch handlers (Closed)

Created:
6 years, 6 months ago by Ian Vollick
Modified:
6 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Do not skip subtrees with wheel or touch handlers When calculating draw properties, we attempt to skip subtrees whenever we can, but we missed a corner case: even though we don't necessarily draw a layer with a wheel or touch handler, it will participate in hit testing and must therefore have up-to-date transforms, targets, etc. In the same way that we've added logic to prevent skipping subtrees containing layers with copy requests, this CL prevents skipping subtrees with handlers. R=danakj@chromium.org BUG=377738 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276877

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M cc/layers/draw_properties.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 4 chunks +20 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ian Vollick
6 years, 6 months ago (2014-06-12 14:17:18 UTC) #1
danakj
LGTM https://codereview.chromium.org/335633003/diff/1/cc/layers/draw_properties.h File cc/layers/draw_properties.h (right): https://codereview.chromium.org/335633003/diff/1/cc/layers/draw_properties.h#newcode32 cc/layers/draw_properties.h:32: layer_or_descendant_has_handler(false), nit: has_input_handler?
6 years, 6 months ago (2014-06-12 18:24:41 UTC) #2
Ian Vollick
On 2014/06/12 18:24:41, danakj wrote: > LGTM > > https://codereview.chromium.org/335633003/diff/1/cc/layers/draw_properties.h > File cc/layers/draw_properties.h (right): > ...
6 years, 6 months ago (2014-06-12 19:45:40 UTC) #3
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-12 19:45:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/335633003/20001
6 years, 6 months ago (2014-06-12 19:49:14 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 01:20:05 UTC) #6
Message was sent while issue was closed.
Change committed as 276877

Powered by Google App Engine
This is Rietveld 408576698