Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/core/fetch/ResourceFetcher.h

Issue 335633002: Oilpan: Fix leaks through RenderStyle objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSFontSelector.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 4 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
5 Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/ 5 Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 void garbageCollectDocumentResourcesTimerFired(Timer<ResourceFetcher>*); 198 void garbageCollectDocumentResourcesTimerFired(Timer<ResourceFetcher>*);
199 void scheduleDocumentResourcesGC(); 199 void scheduleDocumentResourcesGC();
200 200
201 void resourceTimingReportTimerFired(Timer<ResourceFetcher>*); 201 void resourceTimingReportTimerFired(Timer<ResourceFetcher>*);
202 202
203 bool clientDefersImage(const KURL&) const; 203 bool clientDefersImage(const KURL&) const;
204 void reloadImagesIfNotDeferred(); 204 void reloadImagesIfNotDeferred();
205 205
206 HashSet<String> m_validatedURLs; 206 HashSet<String> m_validatedURLs;
207 mutable DocumentResourceMap m_documentResources; 207 mutable DocumentResourceMap m_documentResources;
208 RawPtrWillBeMember<Document> m_document; 208 // FIXME: Oilpan: Ideally this should just be a traced Member but that will
209 // currently leak because RenderStyle and its data are not on the heap.
210 // See crbug.com/383860 for details.
211 RawPtrWillBeWeakMember<Document> m_document;
209 DocumentLoader* m_documentLoader; 212 DocumentLoader* m_documentLoader;
210 213
211 int m_requestCount; 214 int m_requestCount;
212 215
213 OwnPtr<ListHashSet<Resource*> > m_preloads; 216 OwnPtr<ListHashSet<Resource*> > m_preloads;
214 217
215 Timer<ResourceFetcher> m_garbageCollectDocumentResourcesTimer; 218 Timer<ResourceFetcher> m_garbageCollectDocumentResourcesTimer;
216 Timer<ResourceFetcher> m_resourceTimingReportTimer; 219 Timer<ResourceFetcher> m_resourceTimingReportTimer;
217 220
218 typedef HashMap<Resource*, RefPtr<ResourceTimingInfo> > ResourceTimingInfoMa p; 221 typedef HashMap<Resource*, RefPtr<ResourceTimingInfo> > ResourceTimingInfoMa p;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 m_loader->m_allowStaleResources = m_previousState; 266 m_loader->m_allowStaleResources = m_previousState;
264 } 267 }
265 private: 268 private:
266 ResourceFetcher* m_loader; 269 ResourceFetcher* m_loader;
267 bool m_previousState; 270 bool m_previousState;
268 }; 271 };
269 272
270 } // namespace WebCore 273 } // namespace WebCore
271 274
272 #endif 275 #endif
OLDNEW
« no previous file with comments | « Source/core/css/CSSFontSelector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698