Avoid collecting symbol info for one-off preparsing.

Avoid collecting symbol info for one-off preparsing.

[Mads Ager (chromium), 2010-09-08 13:55:25]

http://codereview.chromium.org/3356010/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/3356010/diff/1/2#newcode280
src/compiler.cc:280: // TODO(lrn): Maybe *only* collect function info, not
symbol info, in
So, this is now done. Should you remove the FLAG_lazy part of the conjunction?
At least you should update the comment.

http://codereview.chromium.org/3356010/diff/1/3
File src/parser.cc (right):

http://codereview.chromium.org/3356010/diff/1/3#newcode968
src/parser.cc:968: protected:
Could you leave a blank line before protected?

http://codereview.chromium.org/3356010/diff/1/3#newcode1290
src/parser.cc:1290: class InlinePreParser : public PreParser {
I don't like the name. What is inline about it? Can we call it PartialPreParser
to match the CompletePreParser name above?

http://codereview.chromium.org/3356010/diff/1/3#newcode5476
src/parser.cc:5476: ScriptDataImpl* PreParseInline(Handle<String> source,
Again, I would prefer a different name.

http://codereview.chromium.org/3356010/diff/1/4
File src/parser.h (right):

http://codereview.chromium.org/3356010/diff/1/4#newcode223
src/parser.h:223: unibrow::CharacterStream* stream,
Funky indentation.

[Lasse Reichstein, 2010-09-09 11:10:51]

http://codereview.chromium.org/3356010/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/3356010/diff/1/2#newcode280
src/compiler.cc:280: // TODO(lrn): Maybe *only* collect function info, not
symbol info, in
Removed TODO. Flag should not be removed (no need for preparsing function
declarations if we don't skip anything anyway).

http://codereview.chromium.org/3356010/diff/1/3
File src/parser.cc (right):

http://codereview.chromium.org/3356010/diff/1/3#newcode968
src/parser.cc:968: protected:
Line inserted before protected.

http://codereview.chromium.org/3356010/diff/1/3#newcode1290
src/parser.cc:1290: class InlinePreParser : public PreParser {
Done.

http://codereview.chromium.org/3356010/diff/1/3#newcode5476
src/parser.cc:5476: ScriptDataImpl* PreParseInline(Handle<String> source,
Made Partial.

http://codereview.chromium.org/3356010/diff/1/4
File src/parser.h (right):

http://codereview.chromium.org/3356010/diff/1/4#newcode223
src/parser.h:223: unibrow::CharacterStream* stream,
Fixed.

[Mads Ager (chromium), 2010-09-09 11:29:06]

LGTM