Added a test that currently is able to print to pdf.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 3366 matching lines @@
       FPDF_GetPageSizeByIndex(doc, page_number, &page_width, &page_height);
       if (page_width > *max_page_width) {
         *max_page_width = page_width;
       }
     }
   }
   FPDF_CloseDocument(doc);
   return true;
 }
 
+bool PDFiumEngineExports::GetPDFPageSizeByIndex(
+    const void* pdf_buffer,
+    int buffer_size,
+    int index,
+    double* width,
+    double* height) {
+  FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, buffer_size, NULL);
+  bool ret_value;
+
+  if (!doc)
+    return false;
+
+  if (!FPDF_GetPageSizeByIndex(doc, index, width, height))
+    ret_value = false;
+
+  FPDF_CloseDocument(doc);
+  ret_value = true;

[Dan Beam, 2014/07/07 23:08:12]

just always return true, ret_value is always overwritten here...

[ivandavid, 2014/07/08 01:07:42]

Done.

[ivandavid, 2014/07/08 01:07:42]

Oops. Didn't mean to assign it to true there. It actually shouldn't always
return true. I now assign it correctly.

[Lei Zhang, 2014/07/08 01:11:37]

I think what you want is:

if (!doc)
  return false;
bool retval == FPDF_GetPageSizeByIndex(doc, index, width, height) != 0;
FPDF_CloseDocument(doc);
return retval;

[Dan Beam, 2014/07/08 04:25:13]

if we're gonna keep this code, s/retval ==/success =/g

[ivandavid, 2014/07/08 23:24:21]

Done.

+
+  return ret_value;
+}
+
 }  // namespace chrome_pdf