Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: Source/modules/geolocation/GeolocationController.cpp

Issue 335573004: Oilpan: Notify supplements of Page and LocalFrame destruction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase and null check Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationController.cpp
diff --git a/Source/modules/geolocation/GeolocationController.cpp b/Source/modules/geolocation/GeolocationController.cpp
index 335cd6a163e8cc02f579c22f9057dba81d52602f..cb174270ca2b92fd0f61eade3a93316ea63cef29 100644
--- a/Source/modules/geolocation/GeolocationController.cpp
+++ b/Source/modules/geolocation/GeolocationController.cpp
@@ -90,12 +90,19 @@ GeolocationController::~GeolocationController()
m_client->controllerForTestRemoved(this);
}
+// FIXME: Oilpan: Once GeolocationClient is on-heap m_client should be a strong
+// pointer and |willBeDestroyed| can potentially be removed from Supplement.
void GeolocationController::willBeDestroyed()
{
if (m_client)
m_client->geolocationDestroyed();
}
+void GeolocationController::persistentHostHasBeenDestroyed()
+{
+ observeContext(0);
+}
+
PassOwnPtrWillBeRawPtr<GeolocationController> GeolocationController::create(LocalFrame& frame, GeolocationClient* client)
{
return adoptPtrWillBeNoop(new GeolocationController(frame, client));
« no previous file with comments | « Source/modules/geolocation/GeolocationController.h ('k') | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698