Files.app: Specify the size of file type icons explicitly.

Files.app: Specify the size of file type icons explicitly.

For some devices, we does not include 2x theme assets.  But the devices can be
connected HiDPI displays. In that case, 2x assets are routed to fallback 1x
assets. To show the fallbacks in correct size, we need to specify the icon size
explicitly.

BUG=382971
TEST=remove chrome_200_percent.pak and launch chrome with '--force-device-scale-factor=2'
R=fukino@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276569

[hirono, 2014-06-12 04:50:05]

PTAL the CL? Thank you!

[fukino, 2014-06-12 04:58:38]

On 2014/06/12 04:50:05, hirono wrote:
> PTAL the CL? Thank you!

Can we include 2x theme assets for devices which can be connected HiDPI
displays?
I think it is better if possible.

[hirono, 2014-06-12 05:21:48]

On 2014/06/12 04:58:38, fukino wrote:
> On 2014/06/12 04:50:05, hirono wrote:
> > PTAL the CL? Thank you!
> 
> Can we include 2x theme assets for devices which can be connected HiDPI
> displays?
> I think it is better if possible.

I file another bug crbug.com/383729 for this. Can I handle this separately?
chrome_200_percent.pak is 7MB. And 4K displays are not common currently.
So additional 7MB for uncommon usage can be a discussion, I think.

[fukino, 2014-06-12 05:28:55]

On 2014/06/12 05:21:48, hirono wrote:
> On 2014/06/12 04:58:38, fukino wrote:
> > On 2014/06/12 04:50:05, hirono wrote:
> > > PTAL the CL? Thank you!
> > 
> > Can we include 2x theme assets for devices which can be connected HiDPI
> > displays?
> > I think it is better if possible.
> 
> I file another bug crbug.com/383729 for this. Can I handle this separately?
> chrome_200_percent.pak is 7MB. And 4K displays are not common currently.
> So additional 7MB for uncommon usage can be a discussion, I think.

I see. Thank you for explanation.
LGTM for this CL.

[hirono, 2014-06-12 05:32:41]

On 2014/06/12 05:28:55, fukino wrote:
> On 2014/06/12 05:21:48, hirono wrote:
> > On 2014/06/12 04:58:38, fukino wrote:
> > > On 2014/06/12 04:50:05, hirono wrote:
> > > > PTAL the CL? Thank you!
> > > 
> > > Can we include 2x theme assets for devices which can be connected HiDPI
> > > displays?
> > > I think it is better if possible.
> > 
> > I file another bug crbug.com/383729 for this. Can I handle this separately?
> > chrome_200_percent.pak is 7MB. And 4K displays are not common currently.
> > So additional 7MB for uncommon usage can be a discussion, I think.
> 
> I see. Thank you for explanation.
> LGTM for this CL.

Thank you.
And it looks the bug I filed was closed. So they don't include the 2x assets
intentionally.
Besides the recent change stops to use HiDPI for the external 4K display.

[hirono, 2014-06-12 05:32:45]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-12 05:38:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/335563002/1

[hirono, 2014-06-12 07:48:00]

Committed patchset #1 manually as r276569 (presubmit successful).