Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/gyp/configurations.gypi

Issue 335523003: Work around the crash in GYP's ninja generator on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/configurations.gypi
diff --git a/tools/gyp/configurations.gypi b/tools/gyp/configurations.gypi
index ddbe770b68a9d9ef89c6f793daf3fff696a4609e..45a5850b8d66c6b4300e72f8ba85371478cdc0ea 100644
--- a/tools/gyp/configurations.gypi
+++ b/tools/gyp/configurations.gypi
@@ -368,6 +368,21 @@
'Release': {
'inherit_from': ['Release<(chrome_target_os)<(dart_target_arch)']
},
+
+ 'conditions': [
+ # On Windows ninja generator has hardcorded configuration naming
+ # patterns and it expects that x64 configurations are named smth_x64.
+ # This is a workaround for the crash that these expectations cause.
+ [ 'OS=="win" and GENERATOR=="ninja"', {
+ 'DebugX64_x64': {
+ 'inherit_from': [ 'DebugX64' ]
+ },
+
+ 'ReleaseX64_x64': {
+ 'inherit_from': [ 'ReleaseX64' ]
+ },
+ }],
+ ],
},
},
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698