Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335483003: Revert "Re-styled the App Info Dialog according to UI feedback" (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
Reviewers:
sashab
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert "Re-styled the App Info Dialog according to UI feedback" > Re-styled the App Info Dialog according to UI feedback > > Changed the layout of the App Info Dialog according to UI feedback. This > includes removing the tabs, and replacing it with a single, scrollable > dialog that has all the information in a single pane. > > BUG=364681, 266739 > > Review URL: https://codereview.chromium.org/327743002 Failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30914 TBR=sashab BUG=364681, 266739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1508 lines, -1462 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +35 lines, -35 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc View 2 chunks +20 lines, -44 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc View 1 chunk +0 lines, -319 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_manage_tab.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_manage_tab.cc View 1 chunk +15 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc View 1 chunk +0 lines, -171 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc View 1 chunk +495 lines, -0 lines 0 comments Download
A + chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc View 7 chunks +78 lines, -33 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 1 chunk +0 lines, -271 lines 0 comments Download
A + chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.h View 3 chunks +43 lines, -26 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc View 1 chunk +650 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
Committed patchset #1 manually as r276638 (tree was closed).
6 years, 6 months ago (2014-06-12 12:33:52 UTC) #1
Paweł Hajdan Jr.
6 years, 6 months ago (2014-06-12 12:34:26 UTC) #2
Message was sent while issue was closed. 
TBR

Powered by Google App Engine
This is Rietveld 408576698