Issue 335473003: Rename kIs64BitArch with kRequiresCodeRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335473003: Rename kIs64BitArch with kRequiresCodeRange. (Closed)

Created:
6 years, 6 months ago by haitao.feng

Modified:
6 years, 6 months ago

Reviewers:
Sven Panne, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rename kIs64BitArch with kRequiresCodeRange. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21800

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	src/api.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+4 lines, -2 lines	1 comment	Download
M	src/spaces.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

x32 also requires code range with V8_HOST_ARCH_32_BIT and currently we set its maximal code range ...

6 years, 6 months ago (2014-06-12 02:15:10 UTC) #1

Sven Panne

Just a quick drive-by comment, because I had this buggy CL in my local checkout... ...

6 years, 6 months ago (2014-06-12 11:46:11 UTC) #4

haitao.feng

6 years, 6 months ago (2014-06-12 12:27:50 UTC) #5

Message was sent while issue was closed.

Sven, thanks for the comments :)

I am using int as I noticed code_range_size_'s type is int in include/v8.h. I
will submit a CL to replace all the int with size_t.

Expand Messages | Collapse Messages