Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335473002: Guarded shrink setting with ifdefs to make clear where it is used. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
palmer, Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Guarded shrink setting with ifdefs to make clear where it is used. Shrink value passed over IPC only in if defined (OS_WIN && !WIN_PDF_METAFILE_FOR_PRINTING) This build config should be gone in near future. PrintedPage::shrink_factor_ is used only for OS_WIN. BUG=379961 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276610

Patch Set 1 #

Patch Set 2 : Wed 06/11/2014 17:21:51.00 #

Patch Set 3 : Thu 06/12/2014 0:59:45.49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -74 lines) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper_pdf_win.cc View 1 2 6 chunks +8 lines, -29 lines 0 comments Download
M printing/printed_document.h View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M printing/printed_document.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M printing/printed_page.h View 1 2 3 chunks +11 lines, -5 lines 0 comments Download
M printing/printed_page.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M printing/printed_page_unittest.cc View 1 2 1 chunk +20 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-12 00:21:33 UTC) #1
palmer
LGTM. (Nit: Fix the typos in the commit message: "unnecessary" and "shrink".)
6 years, 6 months ago (2014-06-12 00:35:54 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 00:49:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/335473002/20001
6 years, 6 months ago (2014-06-12 00:50:45 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 07:10:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/335473002/100001
6 years, 6 months ago (2014-06-12 07:17:02 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 08:00:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/335473002/160001
6 years, 6 months ago (2014-06-12 08:03:55 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 09:34:54 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 09:35:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/335473002/160001
6 years, 6 months ago (2014-06-12 09:38:17 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 09:49:10 UTC) #12
Message was sent while issue was closed. 
Change committed as 276610

Powered by Google App Engine
This is Rietveld 408576698