Chromium Code Reviews

Issue 335463006: Ensure HandleDocumentLoad isn't called if the instance is destroyed (Closed)

Created:
6 years, 6 months ago by raymes
Modified:
6 years, 6 months ago
Reviewers:
bbudge
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Ensure HandleDocumentLoad isn't called if the instance is destroyed This adds a check to PepperPluginInstanceImpl::DidDataFromWebURLResponse to avoid calling the instances HandleDocumentLoad function if the plugin instance is deleted before the function gets called. It also adds a check to PepperURLLoaderHost::Close to avoid trying to access an instance that has already been destroyed. A TODO is also added because the behavior of PepperURLLoaderHost::Close is incorrect. BUG=384197, 372548 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277373

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+14 lines, -3 lines)
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +3 lines, -0 lines 0 comments
M content/renderer/pepper/pepper_url_loader_host.cc View 1 chunk +11 lines, -3 lines 0 comments

Messages

Total messages: 5 (0 generated)
raymes
6 years, 6 months ago (2014-06-13 03:35:02 UTC) #1
bbudge
lgtm
6 years, 6 months ago (2014-06-13 14:51:24 UTC) #2
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-06-16 02:49:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/335463006/1
6 years, 6 months ago (2014-06-16 02:50:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 07:22:13 UTC) #5
Message was sent while issue was closed.
Change committed as 277373

Powered by Google App Engine