Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 335463002: [webcrypto] Remove a special case for AES-KW wrapping/unwrapping. (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Remove a special case for AES-KW wrapping/unwrapping. Now the same export+encrypt / decrypt+import codepath is used as for other wrapping algorithms. The new code is less efficient (creates a temporary raw key), however simplifies things, and allows wrapping to be done on non-raw keys (however because of size constraints is likely to fail). BUG=373544, 245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276890

Patch Set 1 : #

Patch Set 2 : Try to placate a compiler warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -194 lines) Patch
M content/child/webcrypto/platform_crypto.h View 1 1 chunk +7 lines, -31 lines 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 1 7 chunks +38 lines, -52 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 1 1 chunk +4 lines, -20 lines 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 1 5 chunks +17 lines, -91 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
6 years, 6 months ago (2014-06-11 23:47:17 UTC) #1
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-12 19:09:48 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-12 19:17:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/335463002/40001
6 years, 6 months ago (2014-06-12 19:18:00 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-12 19:50:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/335463002/60001
6 years, 6 months ago (2014-06-12 19:53:03 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 02:31:11 UTC) #7
Message was sent while issue was closed.
Change committed as 276890

Powered by Google App Engine
This is Rietveld 408576698