Add SBX_CHROME_API_RQ to nacl_helper env whitelist

components/nacl/zygote/nacl_fork_delegate_linux.cc

Index: components/nacl/zygote/nacl_fork_delegate_linux.cc
diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.cc b/components/nacl/zygote/nacl_fork_delegate_linux.cc
index 72d351fc78703747fef1d30383d267fa923c32f6..cc60b7537e948df5ed8ae9894e56bd496cd36f0e 100644
--- a/components/nacl/zygote/nacl_fork_delegate_linux.cc
+++ b/components/nacl/zygote/nacl_fork_delegate_linux.cc
@@ -57,6 +57,7 @@ char kNaClEnvPassthroughDelimiter = ',';
 const char kNaClExeStderr[] = "NACL_EXE_STDERR";
 const char kNaClExeStdout[] = "NACL_EXE_STDOUT";
 const char kNaClVerbosity[] = "NACLVERBOSITY";
+const char kSbxChromeApiRq[] = "SBX_CHROME_API_RQ";

[jln (very slow on Chromium), 2014/06/18 23:14:38]

Could you include sandbox/linux/suid/sandbox.h instead and use
kSandboxEnvironmentApiRequest?

Another possibility would be to add some GetSandboxAPIEnvironmentVariables() API
to the SetuidSandboxClient class that could add variables to a vector<string>
(and would add only this one) and simply call this from
AddPassthroughEnvToOptions.

[elijahtaylor1, 2014/06/18 23:48:18]

I did the first suggestion because the second seemed like overkill to me.

 
 #if defined(ARCH_CPU_X86)
 bool NonZeroSegmentBaseIsSlow() {
@@ -430,6 +431,7 @@ void NaClForkDelegate::AddPassthroughEnvToOptions(
   pass_through_vars.push_back(kNaClExeStderr);
   pass_through_vars.push_back(kNaClExeStdout);
   pass_through_vars.push_back(kNaClVerbosity);
+  pass_through_vars.push_back(kSbxChromeApiRq);
   for (size_t i = 0; i < pass_through_vars.size(); ++i) {
     std::string temp;
     if (env->GetVar(pass_through_vars[i].c_str(), &temp))