Add SBX_CHROME_API_RQ to nacl_helper env whitelist

Add SBX_CHROME_API_RQ to nacl_helper env whitelist

This suppresses a warning about the setuid sandbox API version on Linux.

BUG=385995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278512

[elijahtaylor1, 2014-06-18 22:39:49]

PTAL

@jln: do tests run with the setuid sandbox ever?  Is this testable at all?

[jln (very slow on Chromium), 2014-06-18 23:14:38]

https://codereview.chromium.org/335453009/diff/1/components/nacl/zygote/nacl_...
File components/nacl/zygote/nacl_fork_delegate_linux.cc (right):

https://codereview.chromium.org/335453009/diff/1/components/nacl/zygote/nacl_...
components/nacl/zygote/nacl_fork_delegate_linux.cc:60: const char
kSbxChromeApiRq[] = "SBX_CHROME_API_RQ";
Could you include sandbox/linux/suid/sandbox.h instead and use
kSandboxEnvironmentApiRequest?

Another possibility would be to add some GetSandboxAPIEnvironmentVariables() API
to the SetuidSandboxClient class that could add variables to a vector<string>
(and would add only this one) and simply call this from
AddPassthroughEnvToOptions.

[elijahtaylor1, 2014-06-18 23:48:18]

https://codereview.chromium.org/335453009/diff/1/components/nacl/zygote/nacl_...
File components/nacl/zygote/nacl_fork_delegate_linux.cc (right):

https://codereview.chromium.org/335453009/diff/1/components/nacl/zygote/nacl_...
components/nacl/zygote/nacl_fork_delegate_linux.cc:60: const char
kSbxChromeApiRq[] = "SBX_CHROME_API_RQ";
On 2014/06/18 23:14:38, jln wrote:
> Could you include sandbox/linux/suid/sandbox.h instead and use
> kSandboxEnvironmentApiRequest?
> 
> Another possibility would be to add some GetSandboxAPIEnvironmentVariables()
API
> to the SetuidSandboxClient class that could add variables to a vector<string>
> (and would add only this one) and simply call this from
> AddPassthroughEnvToOptions.

I did the first suggestion because the second seemed like overkill to me.

[jln (very slow on Chromium), 2014-06-19 00:00:51]

lgtm

[elijahtaylor1, 2014-06-19 18:08:53]

The CQ bit was checked by elijahtaylor@chromium.org

[commit-bot: I haz the power, 2014-06-19 18:09:42]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/335453009/20001

[commit-bot: I haz the power, 2014-06-19 18:44:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 18:44:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[elijahtaylor1, 2014-06-19 18:52:22]

@mseaborn: Can I get an OWNERS review?

[Mark Seaborn, 2014-06-19 22:19:03]

On 2014/06/19 18:52:22, elijahtaylor1 wrote:
> @mseaborn: Can I get an OWNERS review?

LGTM.  Maybe say in the commit message that this is just suppressing a warning?

[elijahtaylor1, 2014-06-19 22:25:08]

The CQ bit was checked by elijahtaylor@chromium.org

[commit-bot: I haz the power, 2014-06-19 22:27:11]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/335453009/20001

[commit-bot: I haz the power, 2014-06-19 22:38:14]

Change committed as 278512