Issue 335453007: Introduce new runtime feature state "deprecated" and use it for showModalDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335453007: Introduce new runtime feature state "deprecated" and use it for showModalDialog (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
jamesr, abarth-chromium, Andrew T Wilson (Slow), eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Introduce new runtime feature state "deprecated" and use it for showModalDialog The state is an alias for testing, however, it makes it easier to see that the feature is slated for removal, not launch. BUG=345831 R=abarth@chromium.org,eseidel@chromium.org,jamesr@chromium.org,atwilson@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176540

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	Source/build/scripts/make_runtime_features.py	View		4 chunks	+7 lines, -2 lines	0 comments	Download
	M	Source/platform/RuntimeEnabledFeatures.in	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

jochen (gone - plz use gerrit)

Drew, is the policy side done? ptal

6 years, 6 months ago (2014-06-17 03:54:05 UTC) #1

jochen (gone - plz use gerrit)

The CQ bit was checked by jochen@chromium.org

6 years, 6 months ago (2014-06-19 19:12:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/335453007/1

6 years, 6 months ago (2014-06-19 19:13:23 UTC) #4

Message was sent while issue was closed.

Change committed as 176540