Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335453002: Remove unused cruft from GraphicsLayer (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
jamesr, esprehn
CC:
esprehn, blink-layers+watch_chromium.org, blink-reviews, Rik, danakj, krit, jamesr, jbroman, ojan, pdr., rwlbuis, Stephen Chennney, Ian Vollick
Project:
blink
Visibility:
Public.

Description

Remove unused cruft from GraphicsLayer This CL deletes a bunch of state and code from GraphicsLayer that's not used. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176005

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -195 lines) Patch
M Source/platform/graphics/GraphicsLayer.h View 10 chunks +4 lines, -35 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 7 chunks +12 lines, -15 lines 0 comments Download
D Source/web/tests/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
D Source/web/tests/data/layer_background_color.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 23:34:38 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-06-11 23:35:24 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 23:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/335453002/1
6 years, 6 months ago (2014-06-11 23:37:34 UTC) #4
esprehn
https://codereview.chromium.org/335453002/diff/1/Source/web/tests/CompositedLayerMappingTest.cpp File Source/web/tests/CompositedLayerMappingTest.cpp (left): https://codereview.chromium.org/335453002/diff/1/Source/web/tests/CompositedLayerMappingTest.cpp#oldcode99 Source/web/tests/CompositedLayerMappingTest.cpp:99: registerMockedHttpURLLoad("layer_background_color.html"); Shouldn't you delete this html file too?
6 years, 6 months ago (2014-06-11 23:38:20 UTC) #5
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 00:08:18 UTC) #6
abarth-chromium
On 2014/06/11 at 23:38:20, esprehn wrote: > https://codereview.chromium.org/335453002/diff/1/Source/web/tests/CompositedLayerMappingTest.cpp > File Source/web/tests/CompositedLayerMappingTest.cpp (left): > > https://codereview.chromium.org/335453002/diff/1/Source/web/tests/CompositedLayerMappingTest.cpp#oldcode99 ...
6 years, 6 months ago (2014-06-12 00:08:34 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 03:34:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/335453002/20001
6 years, 6 months ago (2014-06-12 03:36:14 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:22:39 UTC) #10
Message was sent while issue was closed. 
Change committed as 176005

Powered by Google App Engine
This is Rietveld 408576698