runtime/vm/stub_code_x64.cc - Issue 335443002: Setup R10/EDX to be valid Oops before stub calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 335443002: Setup R10/EDX to be valid Oops before stub calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_x64.cc

diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc

index e3213769d71924ec99a1ef7ca433b2571e4a89be..e13b54fea0a482c5cff932119d622f9ce6c25cc6 100644

--- a/runtime/vm/stub_code_x64.cc

+++ b/runtime/vm/stub_code_x64.cc

@@ -83,6 +83,7 @@ void StubCode::GenerateCallToRuntimeStub(Assembler* assembler) {

__ movq(Address(RSP, isolate_offset), CTX); // Set isolate in NativeArgs.

// There are no runtime calls to closures, so we do not need to set the tag

// bits kClosureFunctionBit and kInstanceFunctionBit in argc_tag_.

+ __ SmiUntag(R10);

__ movq(Address(RSP, argc_tag_offset), R10); // Set argc in NativeArguments.

__ leaq(RAX, Address(RBP, R10, TIMES_8, 1 * kWordSize)); // Compute argv.

__ movq(Address(RSP, argv_offset), RAX); // Set argv in NativeArguments.