Issue 335413003: Added unprefixed version of Touch radius and force

Issue 335413003: Added unprefixed version of Touch radius and force (Closed)

Created:
6 years, 6 months ago by gnana

Modified:
6 years, 6 months ago

Reviewers:
aelias_OOO_until_Jul13, Rick Byers

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Added unprefixed version of Touch radius and force Adding unprefixed version of Touch radius and force. https://groups.google.com/a/chromium.org/d/msg/blink-dev/rjLM4KvRrjk/LnEHWYLZE8MJ BUG=378780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176909

Patch Set 2 : incorporated review comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
M	LayoutTests/fast/events/touch/document-create-touch-expected.txt	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/events/touch/script-tests/document-create-touch.js	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/core/dom/Touch.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/dom/Touch.idl	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/web/WebInputEventConversion.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Rick Byers

Thanks! LGTM with nits. https://codereview.chromium.org/335413003/diff/180001/Source/core/dom/Touch.h File Source/core/dom/Touch.h (right): https://codereview.chromium.org/335413003/diff/180001/Source/core/dom/Touch.h#newcode62 Source/core/dom/Touch.h:62: double radiusX() const { return ...

6 years, 6 months ago (2014-06-22 16:58:00 UTC) #2

gnana

Applied review comments. https://codereview.chromium.org/335413003/diff/180001/Source/core/dom/Touch.h File Source/core/dom/Touch.h (right): https://codereview.chromium.org/335413003/diff/180001/Source/core/dom/Touch.h#newcode62 Source/core/dom/Touch.h:62: double radiusX() const { return m_radius.width(); ...

6 years, 6 months ago (2014-06-23 11:08:58 UTC) #3

gnana

+aelias for OWNERS in Source/web/WebInputEventConversion.cpp

6 years, 6 months ago (2014-06-23 11:37:13 UTC) #4

aelias_OOO_until_Jul13

On 2014/06/23 11:37:13, gnana wrote: > +aelias for OWNERS in Source/web/WebInputEventConversion.cpp Lgtm

6 years, 6 months ago (2014-06-24 20:36:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/335413003/200001

6 years, 6 months ago (2014-06-25 04:40:55 UTC) #7

Message was sent while issue was closed.

Change committed as 176909

Expand Messages | Collapse Messages