Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 335413002: Logic fix for switching to Reset screen. (Closed)

Created:
6 years, 6 months ago by merkulova
Modified:
6 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Logic fix for switching to Reset screen. BUG=382630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277888

Patch Set 1 #

Patch Set 2 : Check for default_host added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
merkulova
6 years, 6 months ago (2014-06-17 12:55:51 UTC) #1
Nikita (slow)
I think crash is actually happening here in line 169 157 void CoreOobeHandler::ShowDeviceResetScreen() { 158 ...
6 years, 6 months ago (2014-06-17 14:07:02 UTC) #2
merkulova
Added.
6 years, 6 months ago (2014-06-17 16:43:51 UTC) #3
Nikita (slow)
lgtm
6 years, 6 months ago (2014-06-17 16:51:18 UTC) #4
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-06-17 17:18:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/335413002/20001
6 years, 6 months ago (2014-06-17 17:21:11 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:03:42 UTC) #7
Message was sent while issue was closed.
Change committed as 277888

Powered by Google App Engine
This is Rietveld 408576698