Issue 335403003: DevTools: disable debugger when a profiler is active.

Issue 335403003: DevTools: disable debugger when a profiler is active. (Closed)

Created:
6 years, 6 months ago by loislo

Modified:
6 years, 6 months ago

Reviewers:
vsevik, pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: disable debugger when a profiler is active. this is the first patch. It does only disable debugger if an experiment settings is on. In the following patches will block panel from switching. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176324

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments addressed #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	LayoutTests/inspector/profiler/profiler-test.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/common/Settings.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/DebuggerModel.js	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/335403003/diff/1/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (right): https://codereview.chromium.org/335403003/diff/1/Source/devtools/front_end/common/Settings.js#newcode315 Source/devtools/front_end/common/Settings.js:315: this.disableAgentsWhenProfile = this._createExperiment("disableAgentsWhenProfile", "Disable other agents and UI ...

6 years, 6 months ago (2014-06-17 14:31:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/335403003/2

6 years, 6 months ago (2014-06-17 14:40:58 UTC) #4

Message was sent while issue was closed.

Change committed as 176324

Expand Messages | Collapse Messages