Clarify documentation of contentload, loadcommit, and loadstop for webview

Clarify documentation of contentload, loadcommit, and loadstop for webview

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278437

[Mark Dittmer, 2014-06-17 11:42:22]

Need owners review to commit this documentation change.

[not at google - send to devlin, 2014-06-17 19:06:52]

Fady could you review this? You added yourself as an owner for the webview docs
right?

[Fady Samuel, 2014-06-17 19:08:25]

On 2014/06/17 19:06:52, kalman wrote:
> Fady could you review this? You added yourself as an owner for the webview
docs
> right?

Yup, I am. I asked Mark offline to verify what he wrote. I believe the
documentation for loadstop is slightly off.

[Mark Dittmer, 2014-06-18 19:03:34]

Fady, please take a look at this rewrite. It feels like it might be a bit
verbose, but I am trying to capture the behaviour of loadstop as precisely as I
can.

[Fady Samuel, 2014-06-18 21:09:48]

I love this! Much appreciated Mark! LGTM

[Mark Dittmer, 2014-06-18 22:06:20]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2014-06-18 22:08:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/markdittmer@chromium.org/335403002/20001

[commit-bot: I haz the power, 2014-06-19 05:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 05:35:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Mark Dittmer, 2014-06-19 14:17:23]

Ben, would you please review this? I was under the impression that Fady had been
added to OWNERS here, but it appears I was mistaken.

[not at google - send to devlin, 2014-06-19 14:21:29]

I thought so too. Somebody should arrange that :)

lgtm apart from those 2 comments + don't leave an empty BUG=, either add a BUG
if appropriate, or take it away (though some people like to write BUG=NONE)

https://codereview.chromium.org/335403002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/webview_tag.json (right):

https://codereview.chromium.org/335403002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/webview_tag.json:579: "description": "Fired when
the guest window fires a <code>load</code> event, i.e., when a new document is
loaded. This does <i>not</i> include page navigation within the current document
or asynchronous resource loads. <p>The following example code modifies the
default font size of the guest's <code>body</code> element after the page
loads:</p><pre>webview.addEventListener('contentload', function() {\r 
webview.executeScript({ code: 'document.body.style.fontSize = \"42px\"'
});\r});</pre>",
<em> not <i>

https://codereview.chromium.org/335403002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/webview_tag.json:686: "description": "Fired when a
load has committed. This includes navigation within the current document as well
as subframe document-level loads, but does <i>not</i> include asynchronous
resource loads.",
ditto

https://codereview.chromium.org/335403002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/webview_tag.json:742: "description": "Fired when
all frame-level loads in a guest page (including all its subframes) have
completed. This includes navigation within the current document as well as
subframe document-level loads, but does <i>not</i> include asynchronous resource
loads. This event fires every time the number of document-level loads
transitions from one (or more) to zero. For example, if a page that has already
finished loading (i.e., <code>loadstop</code> already fired once) creates a new
iframe which loads a page, then a second <code>loadstop</code> will fire when
the iframe page load completes. This pattern is commonly observed on pages that
load ads. <p class=\"note\"><strong>Note:</strong> When a committed load is
aborted, a <code>loadstop</code> event will eventually follow a
<code>loadabort</code> event, even if all committed loads since the last
<code>loadstop</code> event (if any) were aborted.</p>",
ditto

[Mark Dittmer, 2014-06-19 14:44:37]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2014-06-19 14:46:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/markdittmer@chromium.org/335403002/40001

[commit-bot: I haz the power, 2014-06-19 18:53:10]

Change committed as 278437