Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 335393005: Do not directly link to EGL/GLESv2 for arm x11 chromeos (Closed)

Created:
6 years, 6 months ago by Daniel Kurtz
Modified:
6 years, 6 months ago
Reviewers:
marcheu, Pawel Osciak, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Do not directly link to EGL/GLESv2 for arm x11 chromeos Chrome will already link to EGL/GLES if/when it needs to. We need not explicitly set these libraries via link settings. This works around the fact that the chromeos arm-generic board does not currently use EGL/GLES. It uses GLX and OpenGL as provided by mesa's xlib-glx. In order to satisfy these hard coded -lEGL -lGLES linker settings, arm-generic was forced to build a dummy EGL/GLES implementation. Without these link settings, we can remove the dummy opengles. BUG=chromium:330163 TEST=build chrome on arm-generic and peach_pi using simple chrome TEST=emerge chromeos-chrome on arm-generic and peach_pi in cros chroot TEST=For peach_pi: build video_encode_accelerator_unittest, scp to device and run TEST=For peach_pi: build video_decode_accelerator_unittest, scp to device and run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/content_common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Daniel Kurtz
6 years, 6 months ago (2014-06-18 01:53:15 UTC) #1
Pawel Osciak
On 2014/06/18 01:53:15, Daniel Kurtz wrote: Looks good, but please add a TEST= line to ...
6 years, 6 months ago (2014-06-18 01:54:46 UTC) #2
Daniel Kurtz
6 years, 6 months ago (2014-06-18 02:05:15 UTC) #3
Pawel Osciak
On 2014/06/18 02:05:15, Daniel Kurtz wrote: lgtm, adding Antoine for OWNERS please.
6 years, 6 months ago (2014-06-18 02:11:59 UTC) #4
piman
Yes, thanks!
6 years, 6 months ago (2014-06-18 20:26:51 UTC) #5
piman
LGTM
6 years, 6 months ago (2014-06-18 20:26:58 UTC) #6
Daniel Kurtz
The CQ bit was checked by djkurtz@chromium.org
6 years, 6 months ago (2014-06-19 11:57:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djkurtz@chromium.org/335393005/1
6 years, 6 months ago (2014-06-19 12:00:32 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 19:34:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/41165)
6 years, 6 months ago (2014-06-19 19:34:35 UTC) #10
Daniel Kurtz
The CQ bit was checked by djkurtz@chromium.org
6 years, 6 months ago (2014-06-20 02:30:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djkurtz@chromium.org/335393005/1
6 years, 6 months ago (2014-06-20 02:33:51 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 04:51:08 UTC) #13
Message was sent while issue was closed.
Change committed as 278598

Powered by Google App Engine
This is Rietveld 408576698