Issue 335393002: Should update FontFaceCache version when updating generic font-family settings.

Issue 335393002: Should update FontFaceCache version when updating generic font-family settings. (Closed)

Created:
6 years, 6 months ago by tasak

Modified:
6 years, 6 months ago

Reviewers:
Kunihiko Sakamoto, dglazkov

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Should update FontFaceCache version when updating generic font-family settings. BUG=381612 TEST=fast/text/update-sans-serif-and-recalc-style.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176327

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
A	LayoutTests/fast/text/update-sans-serif-and-recalc-style.html	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/update-sans-serif-and-recalc-style-expected.html	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSFontSelector.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/FontFaceCache.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

non-owner lgtm https://codereview.chromium.org/335393002/diff/1/Source/core/css/FontFaceCache.h File Source/core/css/FontFaceCache.h (right): https://codereview.chromium.org/335393002/diff/1/Source/core/css/FontFaceCache.h#newcode64 Source/core/css/FontFaceCache.h:64: void update() { ++m_version; } "update" sounds ...

6 years, 6 months ago (2014-06-17 10:54:01 UTC) #2

tasak

Thank you for reviewing. https://codereview.chromium.org/335393002/diff/1/Source/core/css/FontFaceCache.h File Source/core/css/FontFaceCache.h (right): https://codereview.chromium.org/335393002/diff/1/Source/core/css/FontFaceCache.h#newcode64 Source/core/css/FontFaceCache.h:64: void update() { ++m_version; } ...

6 years, 6 months ago (2014-06-17 11:36:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/335393002/20001

6 years, 6 months ago (2014-06-17 15:09:26 UTC) #5

Message was sent while issue was closed.

Change committed as 176327

Expand Messages | Collapse Messages