Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 335373002: Fix: AstValueFactory must be internalized before ThrowPendingError. (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix: AstValueFactory must be internalized before ThrowPendingError. R=rossberg@chromium.org BUG=385193 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21872

Patch Set 1 #

Patch Set 2 : (comment fix) #

Patch Set 3 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/ast-value-factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parser.cc View 1 4 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marja
rossberg, ptal. (A test will follow in a separate CL.)
6 years, 6 months ago (2014-06-17 09:34:16 UTC) #1
rossberg
LGTM, but I agree that we should have a test in this CL
6 years, 6 months ago (2014-06-17 09:39:26 UTC) #2
marja
added test, does it lgty?
6 years, 6 months ago (2014-06-17 10:06:32 UTC) #3
rossberg
LGTM
6 years, 6 months ago (2014-06-17 10:36:19 UTC) #4
marja
6 years, 6 months ago (2014-06-17 11:48:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r21872 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698